Fix NPE when manifests don't contain JVM arguments

Fork: 0

fasolo97 / sklauncher

Browse code Fix NPE when manifests don't contain JVM arguments Jackson upgrade exposed/introduced a bug where the JVM half of Minecraft arguments could end up missing in some cases. Not exactly sure if the field was null on the serializing side or just an empty array, but we just fix it by always initializing the fields. master
1 parent 0a5abee commit 2fe96e443567dbf503d060d480e842c7aed2e6fb Henry Le Grys authored on 27 Apr 2022

Browse code

Jackson upgrade exposed/introduced a bug where the JVM half of Minecraft
arguments could end up missing in some cases. Not exactly sure if the
field was null on the serializing side or just an empty array, but we
just fix it by always initializing the fields.

master

1 parent 0a5abee commit 2fe96e443567dbf503d060d480e842c7aed2e6fb

Henry Le Grys authored on 27 Apr 2022

Patch

Unified Split

Showing 3 changed files

Ignore Space Show notes View launcher/src/main/java/com/skcraft/launcher/model/loader/VersionInfo.java

Ignore Space Show notes View launcher/src/main/java/com/skcraft/launcher/model/minecraft/MinecraftArguments.java

Ignore Space Show notes View launcher/src/main/java/com/skcraft/launcher/model/minecraft/VersionManifest.java

Show line notes below